chore: Generate test definitions#4544
Merged
Merged
Conversation
jperals
commented
May 20, 2026
| @@ -0,0 +1,32 @@ | |||
| // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
Member
Author
There was a problem hiding this comment.
These two files are inside test/definitions/visual because they are definitions of visual regression tests, but I intentionally named the build files and process after just "test definitions" and not specifically "visual test definitions" because this approach can be used for other tests, such as integration tests, if we later want to.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4544 +/- ##
=======================================
Coverage 97.42% 97.42%
=======================================
Files 939 939
Lines 29645 29645
Branches 10772 10771 -1
=======================================
Hits 28883 28883
- Misses 715 755 +40
+ Partials 47 7 -40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
amanabiy
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds test definitions and builds them into the
libdirectory as part of the build process.Doc:
J5RmAnz6YwPaTest definitions for two components (action card and alert) are added, but they are not run yet (for an example of that, see #4509). Once I can consume them internally I will add the rest.
How has this been tested?
Ran
npm run buildand inspected thetest-definitionsdirectory generated insidelib.Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.